752304 - Logic error in nsHTMLEditor::SetInlinePropertyOnNodeImpl

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

if (nextNode && nextNode->Tag() == aProperty &&
        HasAttrVal(nextNode, aAttribute, *aValue) &&
        IsOnlyAttribute(priorNode, *aAttribute)) {
      // following sib is already right kind of inline node; slide this over into it
      return MoveNode(aNode->AsDOMNode(), nextNode->AsDOMNode(), 0);
    }

Do you spot the bug?  It says "priorNode" instead of "nextNode" on the IsOnlyAttribute line.  Ms2ger's use of MOZ_ASSERT in bug 750079 part a is hit by my editing tests because of this.  Yay for catching bugs via fast failure in comprehensive test suites!

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Patch v1

This will be tested by bug 751842, so I didn't add a separate test.

Comment 3

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/622145252703

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/622145252703