Closed Bug 752335 Opened 12 years ago Closed 12 years ago

Lots of Permanent oranges since CPG landed: Test Failure: controller(): Window could not be initialized.

Categories

(Thunderbird :: Testing Infrastructure, defect)

x86
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 15.0

People

(Reporter: mconley, Assigned: mconley)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

Since compartment-per-global landed (bug 650353), some of our Mozmill tests have started to perma-orange with an error stating that:

Test Failure: controller(): Window could not be initialized.

The Mozmill devs themselves got broken by 650353 (see 751424), and they're rapidly working to fix themselves up.

When their patch lands, we'll have to modify our workaround (bug 666438) in _wait_for_generic_load in test-window-helpers.js, but then we should be back in business.  I just tried an early version of the Mozmill patch with a variation on our workaround with positive results.
Henrik says that the Mozmill team is planning on landing their CPG fix in Mozmill 1.5.12 soon, so we're going to have to upgrade.

We'll also need to change our approach to the window workaround we were doing before.  This patch, combined with an early draft of Henrik's work, had good results in test-fixage.
Assignee: nobody → mconley
Attachment #621449 - Flags: review?(mbanner)
Comment on attachment 621449 [details] [diff] [review]
Fix _wait_for_generic_load to use Mozmill's new controller.windowMap

>+++ b/mail/test/mozmill/shared-modules/test-window-helpers.js
>@@ -731,17 +731,20 @@ function _wait_for_generic_load(aDetails
>-  contentWindow.mozmillDocumentLoaded = true;
>+  let windowId = contentWindow.QueryInterface(Ci.nsIInterfaceRequestor)
>+                              .getInterface(Ci.nsIDOMWindowUtils)
>+                              .outerWindowID;
>+  controller.windowMap.update(windowId, "loaded", true);

You should make use of the new utils.getWindowId() method. I have added it to the latest revision of my patch.
Comment on attachment 621449 [details] [diff] [review]
Fix _wait_for_generic_load to use Mozmill's new controller.windowMap

Mark expressed to me how important it was to get these landed and re-open the tree yesterday, so I've brought them in to comm-central

https://hg.mozilla.org/comm-central/rev/dbfa7c06dbfb

and

https://hg.mozilla.org/comm-central/rev/fda8b20e6b21
Attachment #621449 - Flags: review?(mbanner)
(In reply to Henrik Skupin (:whimboo) from comment #3)
> Comment on attachment 621449 [details] [diff] [review]
> Fix _wait_for_generic_load to use Mozmill's new controller.windowMap
> 
> >+++ b/mail/test/mozmill/shared-modules/test-window-helpers.js
> >@@ -731,17 +731,20 @@ function _wait_for_generic_load(aDetails
> >-  contentWindow.mozmillDocumentLoaded = true;
> >+  let windowId = contentWindow.QueryInterface(Ci.nsIInterfaceRequestor)
> >+                              .getInterface(Ci.nsIDOMWindowUtils)
> >+                              .outerWindowID;
> >+  controller.windowMap.update(windowId, "loaded", true);
> 
> You should make use of the new utils.getWindowId() method. I have added it
> to the latest revision of my patch.

Thanks Henrik - I'll write a follow-up patch to fix that once we get our tree back open.
Looks like it worked. No more Window could not be initialized errors on comm-central.

\o/
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
Whiteboard: [tb-orange]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: