752474 - names of languages in the spelling checker are not sorted

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Amir Aharoni]

The names of the languages in the list of spelling dictionaries is not sorted and apparently random. When many spelling dictionaries are installed, it's very hard to find the needed language. They must be sorted alphabetically.

Comment 1

[Jan Horak [:jhorak]]

Attachment: sort-languages.patch

Fedora users hitting this issue too. They are shown ~ 20 dictionaries just for english. Attaching patch which sort this list.

Comment 2

[Jan Horak [:jhorak]]

Downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=585625

Comment 3

[(no longer active)]

Comment on attachment 8369501 [details] [diff] [review]
sort-languages.patch

Review of attachment 8369501 [details] [diff] [review]:
-----------------------------------------------------------------

We have a number of tests which test the context menu, and you may need to change the expected results of those tests before being able to check this patch in.  Please test on the try server before landing.

Thanks a lot for your patch!

::: toolkit/modules/InlineSpellChecker.jsm
@@ +166,3 @@
>      for (var i = 0; i < list.length; i ++) {
> +      sortedList.push({"spellcheck_id":list[i],
> +                       "spellcheck_label": this.getDictionaryDisplayName(list[i])});

Nit: I think this code will be more readable if you just name these fields id and label.

@@ +166,5 @@
>      for (var i = 0; i < list.length; i ++) {
> +      sortedList.push({"spellcheck_id":list[i],
> +                       "spellcheck_label": this.getDictionaryDisplayName(list[i])});
> +    }
> +    sortedList.sort(function(a, b) { 

Nit: Please remove the trailing space.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Try run - https://tbpl.mozilla.org/?tree=Try&rev=9c33a7d4f339

Comment 5

[Jan Horak [:jhorak]]

Attachment: sort-languages.patch

Fixed nits, do the try test looks good?

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dfc7a6908299

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dfc7a6908299