Closed
Bug 752604
Opened 12 years ago
Closed 12 years ago
Ergonomics improvements for HashTable::rekeyFront
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file)
|
1.29 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
This makes rekeyFront take a const ref and check for the unchanged case. This allows us to unconditionally pass a newly constructed temporary into it. This saves us a few lines and a level of indentation basically everywhere we need to use rekeyFront. Granted, this is only a handful of places, but this still seems to be the cleaner option.
Attachment #621675 -
Flags: review?(luke)
|
||
Updated•12 years ago
|
Attachment #621675 -
Flags: review?(luke) → review+
|
Assignee | |
Comment 1•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b11e6c758c8
|
||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7b11e6c758c8
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in
before you can comment on or make changes to this bug.
Description
•