752814 - Make sure editors can make in-app purchases as long as the app is pending approval

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Reviewer Tools, defect, P3)

Description

[krupa raj[:krupa]]

Make sure editors can make in-app purchases as long as the app is pending approval. However, we should revoke this privilege once the app is made public.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Andy, Kumar - what needs to happen to make this so?

Comment 2

[Kumar McMillan [:kumar]]

When a developer sets up in-app payments they get a key from solitude here: https://github.com/mozilla/solitude/blob/master/lib/sellers/models.py#L55

When the app is in review we could put that key into some kind of forced simulation mode. We don't have that mode yet, we only have an *explicit* simulation mode which is declared in the JWT by the developer (bug 834410). 

In this case, we want the editors to control simulated payments. We could do a forced simulation by adding to the SellerProduct model. In webpay, we could detect when a key is in this mode right around here: https://github.com/mozilla/webpay/blob/master/webpay/pay/views.py#L116

When the app is published we could automatically switch off the forced simulation mode for the payment key.

Comment 3

[Andy McKay]

At this time reviewers don't test in-app payments, although the code is theoretically there.