Closed
Bug 752953
Opened 12 years ago
Closed 12 years ago
Typo in calculation of 'allowExpansion' (result will always be an empty rect) in nsDisplayScrollLayer::ComputeVisibility
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
Details
Attachments
(2 files)
|
1.13 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
|
5.12 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•12 years ago
|
||
Looking at the 'allowExpansion' calculations in nsDisplayOpacity/nsDisplayClip I guess this is what was intended.
Attachment #622017 -
Flags: review?(roc)
|
|
Assignee | |
Comment 2•12 years ago
|
||
I guess the compiler can optimize away the unnecessary initialization and IsEmpty() calculation, it's just simpler to not do it.
Attachment #622019 -
Flags: review?(roc)
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=ef827e2cdd2d
Attachment #622017 -
Flags: review?(roc) → review+
Attachment #622019 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/de3ba7db062a https://hg.mozilla.org/integration/mozilla-inbound/rev/0c40b33bfda5
Target Milestone: --- → mozilla15
|
||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/de3ba7db062a https://hg.mozilla.org/mozilla-central/rev/0c40b33bfda5
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•