Closed
Bug 753050
Opened 12 years ago
Closed 12 years ago
Port |Bug 746859 - Add a play icon to the click-to-play placeholder| to Modern
Categories
(SeaMonkey :: Themes, defect)
SeaMonkey
Themes
Tracking
(seamonkey2.11 fixed)
RESOLVED
FIXED
seamonkey2.12
Tracking | Status | |
---|---|---|
seamonkey2.11 | --- | fixed |
People
(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)
Details
Attachments
(1 file)
5.23 KB,
patch
|
neil
:
review+
philip.chee
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
From the base bug: "With the current plugin click-to-play placeholder you have to read the text to know it's click-to-play. Adding a play icon (triangle pointing right) would give a simpler at a glance understanding of what's going on. I suggest simply taking what is there now, making the Lego brick plugin icon significantly bigger, and sticking a play icon in the middle. It's just a minor change, but I think it could be a nice improvement." As always I copied the image from Winstripe.
Attachment #622086 -
Flags: review?(neil)
Comment 1•12 years ago
|
||
Bah, I have a tree which I can import a binary patch into but no plugins, or a tree with plugins that I can't import a binary patch into...
Updated•12 years ago
|
Attachment #622086 -
Flags: review?(neil) → review+
Assignee | ||
Comment 2•12 years ago
|
||
Comment on attachment 622086 [details] [diff] [review] patch [Checkin: Comments 2 and 5] http://hg.mozilla.org/comm-central/rev/d2208486e26c
Attachment #622086 -
Attachment description: patch → patch [Checkin: Comment 2]
Assignee | ||
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.12
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 622086 [details] [diff] [review] patch [Checkin: Comments 2 and 5] [Approval Request Comment] Regression caused by (bug #): bug 746859 (landed on m-a) User impact if declined: Inconsistency between Classic and Modern Testing completed (on m-c, etc.): c-c Risk to taking this patch (and alternatives if risky): low String changes made by this patch: none
Attachment #622086 -
Flags: approval-comm-aurora?
Comment 4•12 years ago
|
||
Comment on attachment 622086 [details] [diff] [review] patch [Checkin: Comments 2 and 5] a=me
Attachment #622086 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 622086 [details] [diff] [review] patch [Checkin: Comments 2 and 5] http://hg.mozilla.org/releases/comm-aurora/rev/f33caeec80fc
Attachment #622086 -
Attachment description: patch [Checkin: Comment 2] → patch [Checkin: Comments 2 and 5]
Assignee | ||
Updated•12 years ago
|
status-seamonkey2.11:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•