Closed
Bug 753444
Opened 12 years ago
Closed 12 years ago
Remove device space pageSize from setPageSize()
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox16 fixed)
RESOLVED
FIXED
Firefox 16
| Tracking | Status | |
|---|---|---|
| firefox16 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: kats)
Details
Attachments
(1 file)
|
11.34 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
We currently convert the device space page size to be scaled by our current zoom. We should be able to just do this conversion from the cssPageSize. This will remove three of the parameters to setPageSize(). We should also make sure that we change the condition for calling setPageSize() to be a change in the CSS pixel size.
|
Reporter | |
Updated•12 years ago
|
Assignee: nobody → bugmail.mozilla
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #632738 -
Flags: review?(jmuizelaar)
|
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 632738 [details] [diff] [review] Patch This looks lovely to me.
Attachment #632738 -
Flags: review?(jmuizelaar) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/636b108f9729
status-firefox16:
--- → fixed
Target Milestone: --- → Firefox 16
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/636b108f9729
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•