753614 - enable DumpHeapComplete in non-debug builds

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andrew McCreight [:mccr8]]

With bug 701415 in place, I think we should be able to enable DumpHeapComplete in non-debug builds.  That should also include the XPConnect heap dumping code that calls it, as well as the CC's invocation of that code.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: remove some ifdef DEBUGs

Comment 2

[Andrew McCreight [:mccr8]]

Comment on attachment 627298 [details] [diff] [review]
remove some ifdef DEBUGs

Pretty simple patch.  Olli can look at the stuff in nsCycleCollector.cpp, Bill can review the rest.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 627298 [details] [diff] [review]
remove some ifdef DEBUGs

Review of attachment 627298 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsapi.cpp
@@ +2517,2 @@
>  JS_PUBLIC_API(void)
>  JS_PrintTraceThingInfo(char *buf, size_t bufsize, JSTracer *trc, void *thing,

While you're here, can you rename this to JS_GetTraceThingInfo?

Comment 4

[Andrew McCreight [:mccr8]]

Thanks for the quick reviews!  Try run looked good.  I renamed the function and fixed up comments in one or two places.

https://hg.mozilla.org/integration/mozilla-inbound/rev/9efa5af3c1d8

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9efa5af3c1d8

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Excellent! I've been waiting for this.

So, it should be in today's Nightly, correct?

Honza

Comment 7

[Andrew McCreight [:mccr8]]

No, it will be in tomorrow's.

I previously switched on JS details in cycle collector dumps, this is just the final trivial bit to enable producing JS heap dumps, too.