753677 - Visually distinguish between configurable, enumerable and writable properties

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Victor Porof [:vporof][:vp]]

A few visual metaphors for these properties may be nice.

Comment 1

[Victor Porof [:vporof][:vp]]

The "enumerable" part of this bug is mostly taken care of in bug 752834.

Comment 2

[Victor Porof [:vporof][:vp]]

We'll just need a lock icon for the unwritable properties.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Frozen objects should be identified as well:

https://mail.mozilla.org/pipermail/es-discuss/2012-May/022991.html

As a matter of fact, why not indicate all object extensibility characteristics? I imagine a single character at the right side of the object value, with a "float: right" alignment, that reads either F(rozen), S(ealed) or N(on-extensible).

Comment 4

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 5

[Victor Porof [:vporof][:vp]]

(In reply to Panos Astithas [:past] from comment #3)
> Frozen objects should be identified as well:
> 
> https://mail.mozilla.org/pipermail/es-discuss/2012-May/022991.html
> 
> As a matter of fact, why not indicate all object extensibility
> characteristics? I imagine a single character at the right side of the
> object value, with a "float: right" alignment, that reads either F(rozen),
> S(ealed) or N(on-extensible).

How about a followup for this?

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Victor Porof from comment #5)
> (In reply to Panos Astithas [:past] from comment #3)
> > Frozen objects should be identified as well:
> > 
> > https://mail.mozilla.org/pipermail/es-discuss/2012-May/022991.html
> > 
> > As a matter of fact, why not indicate all object extensibility
> > characteristics? I imagine a single character at the right side of the
> > object value, with a "float: right" alignment, that reads either F(rozen),
> > S(ealed) or N(on-extensible).
> 
> How about a followup for this?

I'm fine with that.

Comment 7

[Victor Porof [:vporof][:vp]]

Attachment: v1-2

Part 2: make the variables obey these same rules as properties (I didn't think we need another bug for this).

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 628321 [details] [diff] [review]
v1

Review of attachment 628321 [details] [diff] [review]:
-----------------------------------------------------------------

I very much like the decorations, but they are not terribly intuitive. Can't we add tooltips or something?

Comment 9

[Victor Porof [:vporof][:vp]]

(In reply to Panos Astithas [:past] from comment #8)
> Comment on attachment 628321 [details] [diff] [review]
> v1
> 
> Review of attachment 628321 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I very much like the decorations, but they are not terribly intuitive. Can't
> we add tooltips or something?

Indeed. I was hoping that this will be just temporary, and shorlander will think of something awesome as always.

Comment 10

[Victor Porof [:vporof][:vp]]

Attachment: v1-2-fix

Added tooltips copied CSS bits to gnomestripe and pinstripe as well.

Comment 11

[Panos Astithas (he/him) [:past] (please ni?)]

I like the tooltips! One thing I noticed though, after playing with the patch some more, is that the dotted underline beneath non-writable and non-configurable properties is barely visible next to the dotted separator between properties. Perhaps using a dashed underline will make it more prominent, and also emphasize the color difference between noon-writable and non-configurable properties (due to the extra colored pixels), which is now too subtle.

Comment 12

[Rob Campbell [:rc] (:robcee)]

I could not apply this. Needs a little rebase.

Comment 13

[Victor Porof [:vporof][:vp]]

There are two patches in this bug:
v1: which is part1
v1-2-fix: which is part2 with nits addressed from panos.

I'll address comment 11 and reupload a single patch :)

Comment 14

[Victor Porof [:vporof][:vp]]

Attachment: v-fold

Addressed comments and qfolded. Land me.

Comment 15

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/1bc2c4e1493b

Comment 16

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/1bc2c4e1493b