75372 - Can't drag messages to attachment pane

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

I dunno about other platforms, but on Linux I can't drag a message from the
thread pane into the little white Attachment box.  When I drop it, I get the
``rejection slide'' back to the thread pane.

Comment 1

[Jean-Francois Ducarroz]

reassign to varada

Comment 2

[Steve Green]

Ditto with Windows ME

Comment 3

[Greg K.]

WFM using Mac/2001091311 (0.9.4).

Comment 4

[laurel]

*** Bug 102590 has been marked as a duplicate of this bug. ***

Comment 5

[laurel]

I think the last WFM comments are misplaced... doesn't work on mac (os X or 9.1)
on the branch.  

Comment 6

[(not reading, please use [e-mail] instead)]

taking.  fix in hand (as a favor for shaver).

Comment 7

[(not reading, please use [e-mail] instead)]

Attachment: the fix, at least for now.

Comment 8

[(not reading, please use [e-mail] instead)]

the problem is that a while ago we switched from having different flavors (one 
for messages, one for folders) to one generic type.

this fix gets message dnd to attachment pane working again, but it also allows 
you to drop folders.  if you did such a thing, we alert on sending letting you 
know that we couldn't attach the folder (we give the whole folder uri).

one day, when we clean up messengerdnd.js to have multiple js flavors, we'll 
fix this code again to just work for messeages.  (see #72617 for the cleanup.)  
I'll log a new bug (depending on #72617) so we don't forget.

can I get some reviews?

Comment 9

[Navin Gupta]

r=naving

Comment 10

[(not reading, please use [e-mail] instead)]

fixed on the trunk.

see #102630 for the new bug (about folders)

Comment 11

[Christopher Blizzard (:blizzard)]

Reopening.  This doesn't work on Linux.

Comment 12

[Christopher Blizzard (:blizzard)]

Attachment: fix case in flavour

This fixes the case on the flavour and gets message dragging working on Linux.

Comment 13

[jag (Peter Annema)]

Comment on attachment 57425 [details] [diff] [review]
fix case in flavour

r=jag (ew, shouldn't that flavour be prepended with x-moz-, and possible better
formatted? /me goes to file a bug)

Comment 14

[Robert Ginda]

Comment on attachment 57425 [details] [diff] [review]
fix case in flavour

r=rginda

Comment 15

[(not reading, please use [e-mail] instead)]

Comment on attachment 57425 [details] [diff] [review]
fix case in flavour

sr=sspitzer

thanks blizzard.  

I guess windows code is case insensitive. 

jag logged a bug on me to fix the flavor (x-moz-*) and I'll worry about that
next.


I'm in the middle of fixing dnd for the addressbook re-write, so I'll keep both
issues in mind.

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 57425 [details] [diff] [review]
fix case in flavour

a=dbaron for 0.9.6

Comment 17

[Christopher Blizzard (:blizzard)]

Fix checked into the trunk and the 0.9.6 branch.

Comment 18

[Trix Supremo]

verified fix w/ 2002022203 on linux, mac, & WIN32