753758 - Saving a canvas state doesn't carry mozFillRule

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Tobias Schneider [:tobytailor]]

When calling save() on a CanvasRenderingContext2D instance, the current value of mozFillRule seems not to be carried, instead it's set to default value 'nonzero'. After restoring the state, it's set back to previous value. Try the following code:

var ctx = document.createElement('canvas').getContext('2d');
ctx.mozFillRule = 'evenodd';
console.log(ctx.mozFillRule); // -> 'evenodd'
ctx.save();
console.log(ctx.mozFillRule); // -> 'nonzero'
ctx.restore();
console.log(ctx.mozFillRule); // -> 'evenodd'

Comment 1

[Yury Delendik (:yury)]

Unable to replicate that with gfx.canvas.azure.enabled=false (and on Windows).

Comment 2

[Yury Delendik (:yury)]

that's just copy'n'paste mistake  http://mxr.mozilla.org/mozilla-central/source/content/canvas/src/nsCanvasRenderingContext2DAzure.cpp#703

Comment 3

[Yury Delendik (:yury)]

Attachment: Fixes state saving for azure

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 622722 [details] [diff] [review]
Fixes state saving for azure

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):

Comment 5

[Jeff Muizelaar [:jrmuizel]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #4)
> Comment on attachment 622722 [details] [diff] [review]
> Fixes state saving for azure
> 
> [Approval Request Comment]
> Regression caused by (bug #): 
> User impact if declined: 
> Testing completed (on m-c, etc.): 
> Risk to taking this patch (and alternatives if risky):

Ignore the approval request comment. That was added by mistake.

Comment 6

[Yury Delendik (:yury)]

Attachment: patch for checkin

Comment 7

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bfa813930749

Comment 8

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/bfa813930749