Closed
Bug 753845
Opened 12 years ago
Closed 12 years ago
Race condition in selectTab causes all manner of badness
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox14 fixed, firefox15 fixed, blocking-fennec1.0 +)
RESOLVED
FIXED
Firefox 15
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(1 file)
2.05 KB,
patch
|
Margaret
:
review+
mfinkle
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
If the runnable in selectTab() starts running before selectTab() finishes, isSelectedTab(tab) fails and a bunch of Important Things (TM) don't happen. Nom'ing for betaN+ blocker since this is probably the root cause for a bunch of bugs I've seen go by (things like titlebar not updating and such).
Attachment #622763 -
Flags: review?(margaret.leibovic)
Comment 1•12 years ago
|
||
Comment on attachment 622763 [details] [diff] [review] Patch Good catch.
Attachment #622763 -
Flags: review?(margaret.leibovic) → review+
Assignee | ||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/33aee46739d7
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 622763 [details] [diff] [review] Patch [Approval Request Comment] Regression caused by (bug #): User impact if declined: randomly things won't update on switching tabs Testing completed (on m-c, etc.): locally Risk to taking this patch (and alternatives if risky): mobile-only String changes made by this patch: none
Attachment #622763 -
Flags: approval-mozilla-aurora?
Updated•12 years ago
|
blocking-fennec1.0: ? → +
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/33aee46739d7
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Attachment #622763 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/039532eb1c0d
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•