753954 - Implement the Australis tabs on Linux

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

The same as bug 743629 but for Linux

Comment 1

[Richard Marti (:Paenglab)]

Attachment: patch for Linux

This patch is a adaption of the Aero implementation.

I took the tab close graphics from the Australis for Linux Spec page <http://people.mozilla.com/~shorlander/files/australis-designSpecs/australis-designSpecs-linux-mainWindow.html>

Comment 2

[Richard Marti (:Paenglab)]

Do we have a Australis tracker bug for Linux?

Comment 3

[Richard Marti (:Paenglab)]

Attachment: patch for Linux v2

Changed the margin and padding of the close button. With previous patch on hovering the close button the tab hover image changed easily to the next tab. This patch should solve this.

Comment 4

[Andreas Nilsson (:andreasn)]

Comment on attachment 623455 [details] [diff] [review]
patch for Linux v2

Looks good ui-wise when I tested on both light and dark themes. The close button needs down and right 1px. ui-r=me with that fixed.

Comment 5

[Andreas Nilsson (:andreasn)]

Comment on attachment 623455 [details] [diff] [review]
patch for Linux v2

closeTab-active.svg have a lots of gaps in the xml (like on line 28), but apart from that all looks good. r=me with that fixed.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: Patch for check-in

Patch addressing the review comments.

Carrying over r+ and ui-r+

Comment 7

[Blake Winton (:bwinton) (:☕️)]

So, I think we need to talk a little about where we should be landing the australis stuff, since I don't really want us to ship a half-done version.  I'm hoping that we get a UX branch of Thunderbird sometime in the not-too-distant future, where we can land these things.  Until then, I think we should hold off on the checkin-needed, and perhaps even revert the previous checked-in patches, until we're all happy that the new theme is done.

Thanks,
Blake.

Comment 8

[Richard Marti (:Paenglab)]

Blake gave the ticket to land -> checkin-needed

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/2b0f84659994