Closed Bug 754059 Opened 12 years ago Closed 12 years ago

Clean up some repetition in Marionette actors/listeners

Categories

(Remote Protocol :: Marionette, defect)

Product:
Remote Protocol
Component:
Marionette
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla15

People

(Reporter: philikon, Assigned: philikon)

Details

Attachments

(1 file, 1 obsolete file)

v2
18.58 KB, patch
jgriffin
: review+
Details | Diff | Splinter Review
Attached patch v1 (obsolete) — — Splinter Review 
There was some repetition that made my eyes hurt.
Attachment #622929 - Flags: review?(jgriffin)
Comment on attachment 622929 [details] [diff] [review]
v1

lgtm
Attachment #622929 - Flags: review?(jgriffin) → review+
Attached patch v2 — — Splinter Review 
Found another couple of lines to simplify.
Assignee: nobody → philipp
Attachment #622929 - Attachment is obsolete: true
Attachment #623046 - Flags: review?(jgriffin)
Comment on attachment 623046 [details] [diff] [review]
v2

Review of attachment 623046 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, thanks for the cleanup!
Attachment #623046 - Flags: review?(jgriffin) → review+
https://hg.mozilla.org/mozilla-central/rev/613ad5b3da7c
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: