754076 - WebApplicationMgmt onuninstall getter doesn't return value

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[David Chan [:dchan]]

314   get onuninstall() {
315     this._onuninstall;
316   },

The above code is different from the oninstall getter() a couple lines above. I'm not sure if this was intended or not.

http://mxr.mozilla.org/mozilla-central/source/dom/base/Webapps.js#314

Comment 1

[David Chan [:dchan]]

Attachment: Add return to get onuninstall

Patch againt services-central

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 622943 [details] [diff] [review]
Add return to get onuninstall

Review of attachment 622943 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Please land that on mozilla-inbound

Comment 3

[Sid Stamm [:geekboy or :sstamm]]

Pushed to inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/97b28a637e8b

Comment 4

[David Chan [:dchan]]

(In reply to Sid Stamm [:geekboy] from comment #3)
> Pushed to inbound:
> http://hg.mozilla.org/integration/mozilla-inbound/rev/97b28a637e8b

Thanks for landing this Sid

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/97b28a637e8b