754894 - Catalog sheet code is broken at least in unpackaged build

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Boris Zbarsky [:bzbarsky]]

It's comparing stylesheet URIs, but bug 670514 changed what the stylesheet URI is in this case.

We need to make a change to nsResProtocolHandler similar to the one in bug 751905.

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1.

I'm not sure what the catalog sheet code is, so I didn't test, but I think this is the desired fix.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 623755 [details] [diff] [review]
Patch v1.

r=me.  Thanks!

You can test, if you really want to, by seeing how often the "do the load" stuff in nsDocument::EnsureCatalogSheet is hit for the same document if you load a document that does SVG stuff.  No way to write an automated test, sadly.  :(

Comment 3

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/3ce1f1bf0cfe

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3ce1f1bf0cfe

Comment 5

[Brian R. Bondy [:bbondy]]

Fixed for Aurora in changeset:
http://hg.mozilla.org/releases/mozilla-aurora/rev/cf5c4540fe22
See Bug 670514

Comment 6

[Brian R. Bondy [:bbondy]]

Thanks for marking.
See Bug 670514
http://hg.mozilla.org/releases/mozilla-beta/rev/7a2c1909e205

Comment 7

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/releases/mozilla-esr10/rev/8ef222645a1a

Comment 8

[u279076]

Is there anything QA needs to do to verify this fix?

Comment 9

[Boris Zbarsky [:bzbarsky]]

No, I don't think so.  Verifying involves basically either attaching a debugger or modifying the code to measure some things...

Comment 10

[u279076]

Okay, thanks Boris. Marking this [qa-] based on that.