754981 - There is not a plain link to a bug (i.e. to the top of the bug) in html bugmail

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect)

Description

[Kent Rogers [:mrbball]]

When only a comment is added to a bug (i.e. no fields are changed) the
html email that is generated does not contain a hyperlink to the top of
the bug (i.e. http://.../show_bug.cgi?id=XXX).

Instead, the bugmail has a link to the specific comment that was added
(i.e. http://.../show_bug.cgi?id=XXX#cYYY).

The link to the comment is not all that useful, since I already have the
text of the comment in my mailer.  I usually want to go to the top of
the bug, not the specific comment.  In general, this is annoying, but
when a bug has dozens or even hundreds of comments and the hyperlink
takes me to the bottom, it's quite sub-optimal.

I guess a link to the specific comment doesn't hurt, but there should
certainly be a link to the bug itself.

Comment 1

[Frédéric Buclin]

The plain text email has a link pointing to the bug itself, not its comment, but the HTML format doesn't. Not sure we will fix it for 4.2.x, though.

Comment 2

[Koosha KM]

Attachment: patch - v1

Comment 3

[Koosha KM]

Attachment: patch - v1.0.1

Comment 4

[Frédéric Buclin]

Comment on attachment 624688 [details] [diff] [review]
patch - v1.0.1

>+              on [% "${terms.Bug} # ${bug.id}" FILTER bug_link( bug, { full_url => 1 }) %]

"Bug" should be lowercase, and we don't want # before the bug ID. Also, |FILTER none| is required, else it doesn't pass tests.

Otherwise looks good, and I think this is a good compromise to fix this bug. r=LpSolit

Comment 5

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/email/bugmail.html.tmpl
Committed revision 8240.

Comment 6

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/4.2/
modified template/en/default/email/bugmail.html.tmpl
Committed revision 8089.