Closed
Bug 755045
Opened 12 years ago
Closed 12 years ago
Fix build warnings under layout/
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: jdm, Unassigned)
References
Details
Attachments
(1 file, 1 obsolete file)
No description provided.
Reporter | ||
Comment 1•12 years ago
|
||
Attachment #623819 -
Flags: review?(roc)
Comment on attachment 623819 [details] [diff] [review] <required> Review of attachment 623819 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/generic/nsHTMLCanvasFrame.cpp @@ +85,3 @@ > virtual nsRegion GetOpaqueRegion(nsDisplayListBuilder* aBuilder, > bool* aSnap, > bool* aForceTransparentSurface) { Ah, this is actually a bug!!! The signature changed recently (bug 681192) and I forgot to fix this method! Can you remove the aForceTransparentSurface parameter please?
Blocks: 681192
Reporter | ||
Comment 3•12 years ago
|
||
Attachment #623830 -
Flags: review?(roc)
Reporter | ||
Updated•12 years ago
|
Attachment #623819 -
Attachment is obsolete: true
Attachment #623819 -
Flags: review?(roc)
Comment on attachment 623830 [details] [diff] [review] Fix signed/unsigned warning and correct shadowed method that wasn't updated aong with with its parent class. Review of attachment 623830 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/generic/nsHTMLCanvasFrame.cpp @@ +85,1 @@ > *aForceTransparentSurface = false; Take this out or it won't build
Attachment #623830 -
Flags: review?(roc) → review+
Comment 5•12 years ago
|
||
Looks like the FrameLayerBuilder issue was fixed in bug 754488 and the nsHTMLCanvasFrame issue was fixed in bug 763451.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•