755202 - Simplify GetChildNodesForOperation

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[(no longer active)]

Comment on attachment 623962 [details] [diff] [review]
Patch v1

Review of attachment 623962 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/nsHTMLEditRules.cpp
@@ +5958,5 @@
> +
> +  for (nsIContent* child = node->GetFirstChild();
> +       child;
> +       child = child->GetNextSibling()) {  
> +    nsIDOMNode* node = child->AsDOMNode();

Nit: rename this variable to something like childNode.

@@ +5964,1 @@
>        return NS_ERROR_FAILURE;

Hmm, I'm pretty sure that nsCOMArray is infallible these days, so this shouldn't be necessary...  But if you're not sure, let's leave it in.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/1dac5c37d560