Closed Bug 755491 Opened 12 years ago Closed 12 years ago

sidebar click handler overactive

Categories

(Firefox Graveyard :: SocialAPI, defect)

Product:
Firefox Graveyard
Component:
SocialAPI
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mixedpuppy, Unassigned)

Details

In the sidebar, we use nsIWebProgressListener::onLocationChange to watch for clicks, and move them into browser tabs.  This is causing problems with sidebar providers that change window.location as part of their authentication or api use, resulting in unwanted empty tabs being opened.
fixed https://github.com/mozilla/socialapi-dev/commit/0fdbbc841bd148e52cade2e13d1b3c46d557c7fc

using docShell.isAppTab=true works wonders, fixes login in sidebar, etc.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.