755511 - Revert all in-memory data when aborting versionchange transactions.

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

By the way, this includes reverting the .indexNames property on deleted objectStores.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

This patch won't revert the indexNames property for deleted object stores, will it?

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Sure it will.  Look at the test.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 637100 [details] [diff] [review]
Patch

Review of attachment 637100 [details] [diff] [review]:
-----------------------------------------------------------------

r- due to the deleted object stores thing.

::: dom/indexedDB/test/error_events_abort_transactions_iframe.html
@@ +156,4 @@
>        ok(db.objectStoreNames.contains("foo"), "Has correct objectStore");
> +      ok(db.objectStoreNames.contains("bar"), "Has correct objectStore");
> +
> +      db.close();

Why add this .close() call? Might be nicer to not have that to make sure that we revert even if the database isn't explicitly closed.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

The db.close call is necessary to start the next versionchange transaction.

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/f6b519d4881b