Closed Bug 755563 Opened 12 years ago Closed 10 years ago

Don't load PayPal objects on pages where users cannot make Contributions

Categories

(addons.mozilla.org Graveyard :: Code Quality, defect)

Product:
addons.mozilla.org Graveyard
Component:
Code Quality
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2014-01-21

People

(Reporter: krupa.mozbugs, Assigned: magopian)

Details

(Whiteboard: [qa+]) 

We shouldn't be loading PayPal objects on pages where users cannot make Contributions. This includes pages like search results and browse pages
There's an attempt here: https://github.com/mozilla/zamboni/pull/1602

This may be very naive, I don't have a clue if it's possible to make paypal payments anywhere else than on the addons detail page (I haven't found any from browsing the site), nor if the paypal objects are needed in other places. Please let me know if it's the case.
Assignee: nobody → mathieu
fixed in https://github.com/mozilla/zamboni/commit/0f66ccd72637a444e5a6498df02160a71f181c23
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [qa+]
Target Milestone: --- → 2014-01-21
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.