755781 - Debug tests should always download symbol zip

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Right now our assertion stacks are totally busted because we don't download symbols.

Comment 1

[[e-mail] (:bhearsum)]

I thought we were downloading on demand now, per bug 561754?

Comment 2

[Phil Ringnalda (:philor)]

Yeah, but it ignored bug 561754 comment 30, which said that we would still need to download symbols for all debug tests, since printing assertion stacks requires symbols, and that doesn't know how to download on demand, and download on demand would be pointless since demand is "every single debug test run ever, for all time" because we'll never be assertion-free.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

So who is going to make this happen?

Comment 4

[Chris AtLee [:catlee]]

moi

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Ping?

Comment 6

[Chris AtLee [:catlee]]

pong - this is getting bumped by higher priority work ATM. I may have some time next week to look at it.

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Talked to dbaron a bit, he says if we stopped running the stack fixing scripts on the machines we could process the logs offline to get usable stacks on Mac/Linux.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I would really really like to see this fixed. I just spent hours trying to reproduce assertions locally and failed; if I could get the stacks from tinderbox I wouldn't have had to do that. As it is, I don't know how I'm going to figure out this problem so I can get my code landed.

Comment 9

[Chris AtLee [:catlee]]

Attachment: ignore download_symbols_ondemand for debug tests

Comment 10

[Aki Sasaki (not active)]

Comment on attachment 692461 [details] [diff] [review]
ignore download_symbols_ondemand for debug tests

I'm not sure if I have to make a similar change in mozharness/scripts/desktop_unittest.py.

Adding to my todo list

Comment 11

[Aki Sasaki (not active)]

This is in production.

Comment 12

[Chris AtLee [:catlee]]

Please re-open if this isn't working properly

Comment 13

[Eddy Bruel [:ejpbruel]]

This does not seem to work properly yet for the Jetpack tree. We're hitting an assertion, but aren't seeing any debug symbols in the resulting stack trace (bug 629263)

Comment 14

[(not currently active) Ted Mielczarek]

That bug is marked FIXED, so if there's additional work to do here please file a new bug.