755796 - Contacts API: multiple sorting fields

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gregor Wagner [:gwagner]]

We currently only sort by either first or family name. If 2 entries have the same familyName for example we want to continue sorting based on the first name.

Comment 1

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 2

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 3

[Gregor Wagner [:gwagner]]

Attachment: patch

There was a bug in the first version. Entries can be undefined.

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 625799 [details] [diff] [review]
patch

Review of attachment 625799 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comments addressed

::: dom/contacts/fallback/ContactService.jsm
@@ +89,5 @@
> +      }
> +
> +      if (sortByNameSet) {
> +        result = x.localeCompare(y);
> +      }

nit: add blank line

@@ +106,1 @@
>        return msg.findOptions.sortOrder == 'ascending' ? result : -result;

Do a |let sortOrder = msg.findOptions.sortOrder| like for sortBy and reuse it.

Comment 5

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d529197a47f0

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d529197a47f0