75582 - full page mac plugin mousedown event handling broken

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P1)

Description

[sean echevarria]

full page plugins on mac get 2 mousedown events when they should only get 1.  
Possible cause (?): nsPluginViewer.cpp does not translate 
nsEventStatus_eConsumeNoDefault to NS_ERROR_FAILURE like nsObjectFrame.cpp does 
in nsPluginInstanceOwner::MouseDown.

To test, (requires Beatnik player http://www.beatnik.com/to/?player ), load 
http://www.beatnik.com/software/documentation/music_object34/music/trance.rmf.  
A single click in the scope should switch the display from a waveform scope to 
voice meters.  The player is getting the mousedown twice, so it switches to 
from scope to meters back to scope.  Likewise with green/red mute button on the 
top right.

Comment 1

[sean echevarria]

assigning to Peter.

Comment 2

[Peter Lubczynski]

This important and should be easy to fix.

Comment 3

[Peter Lubczynski]

Looks like this may be a little harder to fix as events in nsPluginViewer come 
directly from the view system whereas events in nsObjectFrame come from the DOM. 

I'm starting a fresh pull on my Mac to debug why this event doesn't get 
consumed.

Comment 4

[Peter Lubczynski]

I put some printf's in and it looks like we are doing the right thing. I'm 
getting:

NS_MOUSE_ACTIVATE
NS_MOUSE_LEFT_BUTTON_DOWN
NS_MOUSE_LEFT_BUTTON_UP

Am I missing something? I tested with a PDF file. I'll double check with Beatnik 
 later before marking WFM.

Moving to Mozilla 1.0.

Comment 5

[sean echevarria]

I did a pull this morning and still see the same behavior.  Also tested with 
full page Flash and see similar problems.  Rt-click on flash content and select 
Zoom In.  The Flash plugin does 2 zoom ins.

Comment 6

[Peter Lubczynski]

-->mozilla 0.9.1

Comment 7

[karnaze (gone)]

Moving to m0.9.2

Comment 8

[Peter Lubczynski]

Hey Brian, if you have some spare time, can you look at this?

Comment 9

[Peter Lubczynski]

Confirming and accpeting...this bad an needs to be fixed for mozilla 0.9.2

The problem here is that in nsObjectFrame::Destroy, mInstanceOwner has a 
refcount of 4 but it's instance is blown away. The vtable is bad. Need to figure 
out some way to be sure we have a valid instance in the owner.

Comment 10

[Peter Lubczynski]

wrong bug, sorry for the SPAM.

Comment 11

[Brian Nesse (gone)]

Ok, what's going on here is that nsMacEventHandler is sending nsPluginViewer an 
NS_MOUSE_ACTIVATE event followed by a mouse down event. The plugin viewer, which 
is looking for the Windows translated NS_PLUGIN_EVENT, blindly passes both events 
to the plugin as mouse clicks.

The attached patch fixes the double events on Mac and attemps to set the focus on 
other platforms as well.

Comment 12

[Brian Nesse (gone)]

Attachment: Patch to eliminate double mouse clicks on Mac

Comment 13

[Peter Lubczynski]

r=peterl

Comment 14

[Marc Attinasi]

sr=attinasi

Comment 15

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 16

[Peter Lubczynski]

Patch checked in, marking FIXED:

new revision: 1.57; previous revision: 1.56

Comment 17

[shrirang khanzode]

this no longer happens. verif  on mac trunk 0619.