Closed Bug 755829 Opened 12 years ago Closed 9 years ago

release_sanity.py shouldn't fail on blank lines

Categories

(Release Engineering :: Release Automation: Other, defect, P3)

Product:
Release Engineering
Component:
Release Automation: Other
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: coop, Unassigned)

Details

(Whiteboard: [release][sanity]) 

We had problems running release_sanity.py during Firefox 13.0b4 because of an extraneous blank line at the end of the l10n changesets file. Our scripts should be smart enough to ignore blank lines.
Agreed. Lower priority than other work, though.
Priority: -- → P3
Looked into this a bit, I think we should make the 'compare' method capable of optionally ignoring leading/trailing whitespace: https://github.com/mozilla/build-tools/blob/master/lib/python/util/file.py#L5.
Product: mozilla.org → Release Engineering
Ship it truncates input data, so this probably isn't worthwhile to fix anymore.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.