Closed
Bug 755961
Opened 12 years ago
Closed 12 years ago
plugin stream decomtamination: nsIPluginStreamListener
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla15
People
(Reporter: jaas, Assigned: jaas)
Details
Attachments
(1 file, 1 obsolete file)
|
50.18 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
nsIPluginStreamListener is unnecessary and complicates our stream handling. We can simplify things by removing it. The trickiest part is that we use QI to figure out what type of stream data we put in NPStream's 'ndata' field. With my patch we always use the same type of stream wrapper object for 'ndata' diffstat: 13 files changed, 147 insertions(+), 275 deletions(-)
Attachment #624596 -
Flags: review?(benjamin)
Doing this should also allow us to remove nsIPluginStreamInfo easily.
nsNPAPIStreamWrapper doesn't need to be a COM object either.
Attachment #624596 -
Attachment is obsolete: true
Attachment #624596 -
Flags: review?(benjamin)
Attachment #624768 -
Flags: review?(benjamin)
|
||
Updated•12 years ago
|
Attachment #624768 -
Flags: review?(benjamin) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/12020cb10ace
Status: NEW → ASSIGNED
pushed to mozilla-central https://hg.mozilla.org/mozilla-central/rev/12020cb10ace
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Target Milestone: --- → mozilla15
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•