Closed
Bug 756167
Opened 12 years ago
Closed 12 years ago
make-makefile test failure if the source path contains perl regexp metacharacters
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla15
People
(Reporter: chrisccoulson, Assigned: chrisccoulson)
Details
Attachments
(1 file)
We get this test failure when running make check in Ubuntu: /usr/bin/perl /build/buildd/firefox-12.0+build1/build-tree/mozilla/build/autoconf/test/runtest /build/buildd/firefox-12.0+build1/build-tree/mozilla/build/autoconf/test/make-makefile.tpl /build/buildd/firefox-12.0+build1/build-tree/mozilla/build/autoconf/test/make-makefile.tpl .. ok All tests successful. Files=1, Tests=4, 1 wallclock secs ( 0.04 usr 0.00 sys + 0.33 cusr 0.08 csys = 0.45 CPU) Result: PASS /usr/bin/perl /build/buildd/firefox-12.0+build1/build-tree/mozilla/build/autoconf/test/runtest /build/buildd/firefox-12.0+build1/build-tree/mozilla/build/autoconf/test/makemakefile.tpm # Test 6 got: "0" (/build/buildd/firefox-12.0+build1/build-tree/mozilla/build/autoconf/test/makemakefile.tpm at line 123) # Expected: "1" (Invalid topdir path) # /build/buildd/firefox-12.0+build1/build-tree/mozilla/build/autoconf/test/makemakefile.tpm line 123 is: ok($FindBin::RealBin =~ m%$path/% ? 1 : 0, 1, 'Invalid topdir path'); /build/buildd/firefox-12.0+build1/build-tree/mozilla/build/autoconf/test/makemakefile.tpm .. Failed 1/36 subtests Test Summary Report ------------------- /build/buildd/firefox-12.0+build1/build-tree/mozilla/build/autoconf/test/makemakefile.tpm (Wstat: 0 Tests: 36 Failed: 1) Failed test: 6 Files=1, Tests=36, 0 wallclock secs ( 0.06 usr 0.00 sys + 0.08 cusr 0.01 csys = 0.15 CPU) Result: FAIL Failed 1/1 test programs. 1/36 subtests failed. make[3]: *** [.ts/makemakefile.tpm] Error 255 make[3]: Leaving directory `/build/buildd/firefox-12.0+build1/build-tree/mozilla/obj-x86_64-linux-gnu/build/autoconf/test' make[2]: *** [check] Error 2 make[2]: Leaving directory `/build/buildd/firefox-12.0+build1/build-tree/mozilla/obj-x86_64-linux-gnu/build' make[1]: *** [check] Error 2 This is because the path contains a perl regexp metacharacter ('+'), and this is not correctly quoted in the test
Assignee | ||
Updated•12 years ago
|
Attachment #624803 -
Flags: review?(coop)
Updated•12 years ago
|
Attachment #624803 -
Flags: review?(coop) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Updated•12 years ago
|
Attachment #624803 -
Attachment is patch: true
Comment 1•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/527400dc53a8
Assignee: nobody → chrisccoulson
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla15
Comment 2•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/527400dc53a8
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•