756316 - Cleanup nsMsgLocalMailFolder::GetSubFolders

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

Attachment: fix

Found that the codes in GetSubFolders() are redundant because the most of the codes done in DiscoverSubFolders().

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: fix

I am sorry that the previous patch can not be compiled.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 624967 [details] [diff] [review]
fix

This patch causes the problem that folder name is not translated.

Comment 3

[David :Bienvenu]

Comment on attachment 624967 [details] [diff] [review]
fix

As a general rule, I'd rather have less code duplicated code in the pluggable stores and more in the core classes, like nsMsgLocalMailFolder, to lessen the burden on new pluggable store implementors. So I'd prefer removing this cdoe from the pluggable stores, if possible.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

(In reply to David :Bienvenu from comment #3)
> Comment on attachment 624967 [details] [diff] [review]
> fix
> 
> As a general rule, I'd rather have less code duplicated code in the
> pluggable stores and more in the core classes, like nsMsgLocalMailFolder, to
> lessen the burden on new pluggable store implementors. So I'd prefer
> removing this cdoe from the pluggable stores, if possible.

At first, I tried to remove the codes in pluggable stores but I quited because directory structure depends on the pluggable store. 

Anyway you are absolutely right. There are still the codes independent from directory structure. Those codes should be in nsLocalMailFolder.cpp.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Fix

This patch needs the fix for bug 759237.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Attachment: Fix

The previous patch allowed to be more cleaned up.

Comment 7

[David :Bienvenu]

Comment on attachment 627873 [details] [diff] [review]
Fix

this is slightly bit-rotted, perhaps by my slight tweaks to your addsubfolders patch. Since I probably bit-rotted you, I'll try to fix it myself and upload a de-bitrotted patch. This looks like a nice cleanup.

Comment 8

[David :Bienvenu]

Attachment: de-bitrotted patch

I'll try this patch...

Comment 9

[David :Bienvenu]

Comment on attachment 628539 [details] [diff] [review]
de-bitrotted patch

looks good, thx very much for the patch!

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/9c0bd4891167

Comment 11

[David :Bienvenu]

Comment on attachment 628539 [details] [diff] [review]
de-bitrotted patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on c-c, etc.): 
Risk to taking this patch (and alternatives if risky):

[Triage Comment]
landing this on aurora and beta makes landing the fix for bug 751652 quite a bit easier. I'm going to land it on aurora and I think we should consider it for beta.

Comment 12

[Mark Banner (:standard8)]

(In reply to David :Bienvenu from comment #11)
> landing this on aurora and beta makes landing the fix for bug 751652 quite a
> bit easier. I'm going to land it on aurora and I think we should consider it
> for beta.

I think that's the wrong bug number.

Comment 13

[David :Bienvenu]

sorry, bug 751562

Comment 14

[David :Bienvenu]

http://hg.mozilla.org/releases/comm-aurora/rev/43254a94f3b1

Comment 15

[Mark Banner (:standard8)]

Comment on attachment 628539 [details] [diff] [review]
de-bitrotted patch

It looks lowish risk, so a=me.

Comment 16

[David :Bienvenu]

fixed for comm-beta - http://hg.mozilla.org/releases/comm-beta/rev/d3988e6258ca