756430 - Missing return statement in DrawTargetD2D::FillGlyphsManual

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jacek Caban]

Attachment: fix v1.0

Found on mingw build thanks to -Werror=return-type. While I was on this I've fixed one more warning about unused variable.

BTW, GCC has many more warnings that seem harmless, like an enum not handled in switch statement. I'm happy to fix them, but I'm not sure it's welcomed. Bas, what do you think?

Comment 1

[Bas Schouten (:bas.schouten)]

(In reply to Jacek Caban from comment #0)
> Created attachment 625074 [details] [diff] [review]
> fix v1.0
> 
> Found on mingw build thanks to -Werror=return-type. While I was on this I've
> fixed one more warning about unused variable.

Ugh, this is just me being blind, our MSVC build warns for this by default as well.

> BTW, GCC has many more warnings that seem harmless, like an enum not handled
> in switch statement. I'm happy to fix them, but I'm not sure it's welcomed.
> Bas, what do you think?

I'm a little indifferent to the specific warning you mentioned, but some may be useful?

Comment 2

[Jacek Caban]

(In reply to Bas Schouten (:bas) from comment #1)
> I'm a little indifferent to the specific warning you mentioned, but some may
> be useful?

I just filled bug 756996 so you can decide seeing the code. Unused variables seem valuable, others are nice to have fixed clean ups so that useful warnings are not shadowed by them.

Comment 3

[Jacek Caban]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dac49054fb1d

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/dac49054fb1d