756514 - Update documentation to reflect that sandbox.importFunction is no longer necessary

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

I'm not sure what it used to do, but it doesn't do anything useful now post-compartments. We should update the docs to tell people they can just define the functions directly on the sandbox.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

For what it's worth, this was necessary before we had automatic wrappers. Simply doing sandbox.function = chromeFunction was unsafe because there were ways of attacking chrome with the function object (or by passing evil objects to it). Now that we have automatic wrappers, importFunction is no longer necessary.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

I just updated https://developer.mozilla.org/en-US/docs/Components.utils.Sandbox - I hope that was the only docs you had in mind, so I'm closing this.

Comment 3

[Will Bamberg [:wbamberg]]

I think dev-doc-needed can be removed from here as per markh's comment 2.