756523 - warning C4013: 'malloc_usable_size' undefined in sqlite3.c

Status: RESOLVED INACTIVE

(Toolkit :: Storage, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Just noticed this today when working on updating SQLite to 3.7.12. Not sure if it's anything serious, but worth filing anyway.

sqlite3.c
e:/builds/moz2_slave/m-in-w32/build/db/sqlite3/src/sqlite3.c(15335) : warning C4013: 'malloc_usable_size' undefined; assuming extern returning int

Comment 1

[Mike Hommey [:glandium]]

It actually doesn't matter at all. The code that calls malloc_usable_size is never used because we register our own memory methods.

Comment 2

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #1)
> It actually doesn't matter at all. The code that calls malloc_usable_size is
> never used because we register our own memory methods.

which means we can probably get rid of http://mxr.mozilla.org/mozilla-central/source/db/sqlite3/src/Makefile.in#154 , which would remove the warning.

Comment 3

[Mike Hommey [:glandium]]

On the other hand, there's bug 719579... is nss using sqlite before we initialize it from storage?

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to Mike Hommey [:glandium] from comment #2)
> which means we can probably get rid of
> http://mxr.mozilla.org/mozilla-central/source/db/sqlite3/src/Makefile.in#154
> , which would remove the warning.

we can't get rid of that, otherwise we end up using _msize and the build crashes badly on win64 (it ends up using _msize instead of malloc_usable_size but then later tries to alloc with our custom allocator thinking we used our malloc_usable_size, not _msize).

Comment 5

[Mike Hommey [:glandium]]

(In reply to Marco Bonardo [:mak] from comment #4)
> (In reply to Mike Hommey [:glandium] from comment #2)
> > which means we can probably get rid of
> > http://mxr.mozilla.org/mozilla-central/source/db/sqlite3/src/Makefile.in#154
> > , which would remove the warning.
> 
> we can't get rid of that, otherwise we end up using _msize and the build
> crashes badly on win64 (it ends up using _msize instead of
> malloc_usable_size but then later tries to alloc with our custom allocator
> thinking we used our malloc_usable_size, not _msize).

The only way i can see for _msize to be called is if sqlite calls its memsize function before we set our memory handling functions. This also means that it may be allocating memory before we set our memory handling functions. I'd say we should try to avoid that.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

This warning still occurs, not sure based on the last comments in this bug whether this is something we need to actively worry about or not, though. I'm guessing not given how long it's sat for, though :)

Comment 7

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.