756576 - nsDOMAttributeMap::Init should be removed

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Benjamin Smedberg]

Now that hashtable init is infallible (bug 734847), nsDOMAttributeMap::Init is also infallible and should be folded into the constructor/removed.

Comment 1

[Josh Matthews [:jdm]]

http://mxr.mozilla.org/mozilla-central/source/content/base/src/nsDOMAttributeMap.cpp

Comment 2

[Jignesh Kakadiya [:jhk]]

Attachment: Patch(v1)

Comment 3

[Jignesh Kakadiya [:jhk]]

Attachment: Patch(v1)

Forget to refresh. Please review this one.

Comment 4

[Benjamin Smedberg]

Comment on attachment 625262 [details] [diff] [review]
Patch(v1)

Great. Do you know how to get this landed or do you need help with that?

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/640557f458be

I had to un-bitrot nsDOMAttributeMap.cpp a bit. Please make sure that I didn't mess it up.

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/640557f458be

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Ryan VanderMeulen from comment #5)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/640557f458be
> 
> I had to un-bitrot nsDOMAttributeMap.cpp a bit. Please make sure that I
> didn't mess it up.

Confirmed.