756745 - xptcall fails to build with mipsel-linux-android target

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Mike Hommey [:glandium]]

/home/mh/mozilla-central/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_asm_mips.s:45:24: error: sys/regdef.h: No such file or directory
/home/mh/mozilla-central/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_asm_mips.s:46:21: error: sys/asm.h: No such file or directory

Comment 1

[Mike Hommey [:glandium]]

There are several issues:
- ASFLAGS don't include CPPFLAGS, which is required to have the proper include path for the android system headers.
- regdef.h and asm.h are not under sys/ in the android system header for mips.
- ASFLAGS don't include -DANDROID which would allow a special case for android.
- There are different asm.h and regdef.h under asm/ and machine/ none of which allow the xptcall assembly to build.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Use CPPFLAGS for defines and forced includes, and add them to ASFLAGS

Note that setting CPPFLAGS directly during configure fails because "$(DEPTH)/mozilla-config.h" is not valid (mozilla-config.h is not yet created, and $(DEPTH) is a make variable, not a shell variable). Thus the use of COMPILE_CPPFLAGS.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Use CPPFLAGS for defines and forced includes, and add them to ASFLAGS

Err, the patch was not meant to contain the *.s files.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Use the "right" headers for mips xptc assembly on android

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 625415 [details] [diff] [review]
Use CPPFLAGS for defines and forced includes, and add them to ASFLAGS

Unfortunately, this breaks windows :(

Comment 6

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #5)
> Comment on attachment 625415 [details] [diff] [review]
> Use CPPFLAGS for defines and forced includes, and add them to ASFLAGS
> 
> Unfortunately, this breaks windows :(

Actually, it only breaks win64, which is kind of surprising.

Comment 7

[Mike Hommey [:glandium]]

Attachment: Add -DANDROID and include path to ASFLAGS when building for Android

Simpler approach, which won't break anything non-Android.

Comment 8

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e31b42950e88
https://hg.mozilla.org/integration/mozilla-inbound/rev/e74adb892275

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/e31b42950e88
https://hg.mozilla.org/mozilla-central/rev/e74adb892275