756783 - Cannot delete event using keyboard or toolbar

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

STR:


1. select an event
2. press the delete button in the toolbar
3. press backspace to delete the event

Results:

Step 2 and 3 produce these errors:

Timestamp: 5/19/12 10:12:57 PM
Error: An error occurred executing the cmd_delete command: TypeError: focusedElement is null
Source File: chrome://global/content/globalOverlay.js
Line: 75

Timestamp: 5/19/12 10:13:08 PM
Error: An error occurred executing the calendar_delete_focused_item_command command: [Exception... "'[JavaScript Error: "focusedElement is null" {file: "chrome://calendar/content/calendar-common-sets.js" line: 331}]' when calling method: [nsIController::doCommand]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://global/content/globalOverlay.js :: goDoCommand :: line 71"  data: yes]
Source File: chrome://global/content/globalOverlay.js
Line: 75


This works in Lightning 1.5, fails in Lightning 1.7. I haven't tested 1.6. I'm testing on Mac, not sure about other platforms.

Comment 1

[Stefan Sitter [:ssitter]]

Seems to work for me using 1.6a2 and 1.7a1 on Windows platform.

We previously had the same problem, Bug 547593. Maybe some change regressed it for Mac OS X?

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

This seems to be off and on. Try these STR:


1. Create Event in Calendar Tab
2. Switch to mail tab, then back to calendar tab
3. Delete event with Backspace

Comment 3

[Stefan Sitter [:ssitter]]

As far as I remember the Backspace key was never available for deleting an event, at least on Windows platform. Steps from Comment 2 work for me using the Delete key in Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Thunderbird/16.0a1 (BuildID: 20120607030200).

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Oh right, sorry. I said backspace because on Mac the Delete key is fn+Backspace. May be a Mac issue then.

Comment 5

[Stefan Sitter [:ssitter]]

Setting qawanted in hope that someone with access to Mac OS X can confirm this as a problem but I still think this doesn't a block development and/or testing work.

Comment 6

[Stefan Sitter [:ssitter]]

No complaints in the last 4 months although we did at another 3 releases -> no blocker.

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Still getting this once in a while, this should fix the error. Can you give it a quick test? My build is totally messed up, but this does seem to fix it for me.

Comment 8

[Mohit Kanwal [:redDragon]]

Comment on attachment 8567085 [details] [diff] [review]
Fix - v1

Review of attachment 8567085 [details] [diff] [review]:
-----------------------------------------------------------------

Although the problem does not seem to occur for me on Mac OSX (I am on 10.10) nonetheless, the patch looks fine to me.

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset 516b43f6d312