Closed
Bug 756887
Opened 12 years ago
Closed 12 years ago
Require.jsm should have support and tests for firebug/NetMonitor style modules
Categories
(DevTools :: General, defect, P1)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 15
People
(Reporter: jwalker, Assigned: jwalker)
References
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(1 file, 1 obsolete file)
|
4.92 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
Also the define statements in the tests should be updated to be more technically correct.
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Summary: Require.jsm should have tests for firebug/NetMonitor style modules → Require.jsm should have support and tests for firebug/NetMonitor style modules
|
|
Assignee | |
Comment 2•12 years ago
|
||
Test driven development at its finest - forgetting where the actual code was in my patch queue, so the tests test code that hasn't been committed yet. Promoting the code so the tests are in with the code. Duh.
Attachment #625508 -
Attachment is obsolete: true
Attachment #625508 -
Flags: review?(rcampbell)
Attachment #625581 -
Flags: review?(rcampbell)
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=2924e2c56f36
|
|
Assignee | |
Comment 4•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=5b32c8cb3ad5
|
|
Assignee | |
Updated•12 years ago
|
Blocks: NetMonitor
|
||
Comment 5•12 years ago
|
||
Comment on attachment 625581 [details] [diff] [review] Upload 2 okay!
Attachment #625581 -
Flags: review?(rcampbell) → review+
|
|
Assignee | |
Comment 6•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=6b8e09a7dc03
|
|
Assignee | |
Comment 7•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Fx-Team&rev=7df3e6796d1f
Whiteboard: [fixed-in-fx-team]
|
||
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e27fa361af61
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•