757278 - Handle positions are not saved.

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Thaddee Tyl [:espadrine]]

The two vertical separators in the debugger pane
can be used to resize the left and right pane.
However, the position of those separators are not
saved after the debugger is closed.

The position should be saved.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: v1.1

Added test.

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 628334 [details] [diff] [review]
v1.1

So this only saves pane state (size) on destroy? Is that often enough?

A little thinking, says it should be... Maybe more thinking required.

-      <vbox id="stack" flex="1">
-        <vbox id="stackframes" class="dbg-default" flex="1"/>
-      </vbox>
-      <splitter id="stack-script-splitter"
-                class="devtools-side-splitter"/>
-      <vbox id="editor" class="dbg-default" flex="1"/>
-      <splitter id="script-properties-splitter"
-                class="devtools-side-splitter"/>
-      <vbox id="properties" flex="1">
-        <vbox id="variables" class="dbg-default" flex="1"/>
-      </vbox>
+      <vbox id="stackframes"/>
+      <splitter id="stack-script-splitter" class="devtools-side-splitter"/>
+      <vbox id="editor" flex="1"/>
+      <splitter id="script-properties-splitter" class="devtools-side-splitter"/>
+      <vbox id="variables"/>
     </hbox>

not *strictly* necessary, but it's acceptable cleanup.

OK!

Comment 4

[Victor Porof [:vporof][:vp]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #3)
> Comment on attachment 628334 [details] [diff] [review]
> v1.1
> 
> So this only saves pane state (size) on destroy? Is that often enough?
> 
> A little thinking, says it should be... Maybe more thinking required.
> 

I can (over)think of a single case: opening a script debugger and a remote debugger at the same time.

> 
> not *strictly* necessary, but it's acceptable cleanup.
>

Quite necessary. The additional flexes didn't let me resize the bastard.

> OK!

^_^

Comment 5

[Victor Porof [:vporof][:vp]]

Attachment: v1.2

Fixed an orange.

Comment 6

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/fd4ff7253be8

Comment 7

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/fd4ff7253be8