Closed
Bug 757469
Opened 12 years ago
Closed 12 years ago
Implement ctypes.off_t
Categories
(Core :: js-ctypes, enhancement)
Core
js-ctypes
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: Yoric, Assigned: Yoric)
References
Details
Attachments
(1 file, 3 obsolete files)
4.62 KB,
patch
|
Details | Diff | Splinter Review |
js-ctypes offers support for size_t and ssize_t, but not for off_t, whose size can generally not be predicted by JS code. I believe we should add a type ctypes.off_t.
Assignee | ||
Updated•12 years ago
|
Severity: normal → enhancement
OS: Mac OS X → All
Hardware: x86 → All
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Comment 2•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #626139 -
Flags: review?(jorendorff)
Comment 3•12 years ago
|
||
Comment on attachment 626139 [details] [diff] [review] Implementing ctypes.off_t > run_wrapped_integer_tests(library, ctypes.size_t, "size_t", ctypes.size_t.size, false, > ctypes.UInt64, "ctypes.UInt64", ulimits); > run_wrapped_integer_tests(library, ctypes.ssize_t, "ssize_t", ctypes.size_t.size, true, > ctypes.Int64, "ctypes.Int64", slimits); >- run_wrapped_integer_tests(library, ctypes.uintptr_t, "uintptr_t", ctypes.size_t.size, false, >- ctypes.UInt64, "ctypes.UInt64", ulimits); >+ run_wrapped_integer_tests(library, ctypes.ssize_t, "ssize_t", ctypes.size_t.size, true, >+ ctypes.Int64, "ctypes.Int64", slimits); > run_wrapped_integer_tests(library, ctypes.intptr_t, "intptr_t", ctypes.size_t.size, true, > ctypes.Int64, "ctypes.Int64", slimits); This bit looks like a mistake. r=me with this reverted.
Attachment #626139 -
Flags: review?(jorendorff) → review+
Assignee | ||
Comment 4•12 years ago
|
||
Fixed, thanks for the quick review.
Attachment #626139 -
Attachment is obsolete: true
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 6•12 years ago
|
||
And backed out for orange. https://hg.mozilla.org/integration/mozilla-inbound/rev/8d4521e975c8 Try FTW? https://tbpl.mozilla.org/php/getParsedLog.php?id=12008893&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=12009164&tree=Mozilla-Inbound
Flags: in-testsuite+
Target Milestone: mozilla15 → ---
Assignee | ||
Comment 7•12 years ago
|
||
Sorry about that. The error was masked by an intermittent orange.
Assignee | ||
Comment 8•12 years ago
|
||
Here we go. Issue was, as often, not in the code but in the (vastly less documented) test.
Attachment #626467 -
Attachment is obsolete: true
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 9•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6de6c3de450d Mommy, I'm scared...
Assignee | ||
Comment 10•12 years ago
|
||
Who wouldn't be?
Comment 11•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6de6c3de450d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•