757592 - Re-enable test for strictness of "newer" parameter.

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Ryan Kelly [:rfkelly]]

As discovered by Bug 744323, the test to check that the "newer" parameter is a strict ">" check is currently disabled.  Note to self to investigate why and to switch it back on post-haste.

Quoting https://github.com/mozilla-services/server-syncstorage/blob/master/syncstorage/tests/functional/test_storage.py#L141:

        res = self.app.get(self.root + '/storage/col2?newer=%s' % ts)
        res = res.json["items"]
        try:
            self.assertEquals(res, ['129'])
        except AssertionError:
            # XXX not sure why this fails sometimes
            pass

Comment 1

[Ryan Kelly [:rfkelly]]

Also, need to add a test for strictness of "older" parameter.

Comment 2

[Toby Elliott [:telliott]]

Something not cleaning itself up properly? Without being able to see what the actual value for res is, that's the most likely culprit behind a heisenbug.

Comment 3

[Ryan Kelly [:rfkelly]]

Attachment: patch to re-enabled and extend strictness checks

Running the tests in a tight loop as not revealed any spurious failures.  I suspect this was a timing issue of some sort, resolved by adding sleeps and/or improving precision of timestamps.

Attached patch re-enables the test and adds a few more for good measure.  If they start failing again, we'll try to track it down then.

Comment 4

[Ryan Kelly [:rfkelly]]

https://github.com/mozilla-services/server-syncstorage/commit/4e0aca8cab028fd98185c2902d518a0f5fb36f2e