Closed
Bug 757594
Opened 12 years ago
Closed 12 years ago
Implicit Makefile rule changes in bug 748001 broke libvpx's obj_int_extract
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: derf, Assigned: derf)
References
Details
Attachments
(1 file)
|
2.14 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
Bug 748001 got rid of some implicit rules that media/libvpx/Makefile.in was relying on to make the obj_int_extract approach to extracting C struct offsets for the libvpx asm work. We didn't notice because a) the decoder only needs these offsets on ARM, and ARM always uses gcc, which does this a much better way (without obj_int_extract), and b) the encoder is not built by default.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → tterribe
Blocks: 748001
Status: NEW → ASSIGNED
OS: Linux → Windows XP
Hardware: x86_64 → x86
|
|
Assignee | |
Comment 1•12 years ago
|
||
Try results with encoder (and error concealment) enabled incoming: https://tbpl.mozilla.org/?tree=Try&rev=e2864eec0017
Attachment #626197 -
Flags: review?(mh+mozilla)
Attachment #626197 -
Flags: review?(mh+mozilla) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/384f2d1f7b49
Flags: in-testsuite-
Target Milestone: --- → mozilla15
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/384f2d1f7b49
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•