757769 - Coping with abandoned apps

Status: RESOLVED FIXED

(Marketplace Graveyard :: Developer Pages, defect)

Description

[Andy McKay]

An app can be removed from the developers site and they might not remove it from the marketplace. We'll still happily be selling or asking people to install it and it will fail.

We can rely on people reporting failed manifests but we might be able to figure this out for them.

The manifest update cron job will find failed manifests.

May 23 01:10:40 celery1.dev.addons.phx1.mozilla.com: [][] z.task:INFO Failed to get manifest for: 364921 : ....
Exception: http://bc-779990590.eu-west-1.elb.amazonaws.com/mywordbook/manifest.webapp responded with 404 (Not Found).

Automatically removing it wouldn't be nice if there's a temporary network hiccup, but if it keeps failing, we should do something.

Comment 1

[Wil Clouser [:clouserw]]

I'd say add get_failure_date and get_failure_count.  If count gets above 30 put it in the review queue (that gives them a little over a day to get their server back up, we can adjust as necessary).  If there is a success it resets both new columns.  Continuing failures only increments the count, not the date, so you can see when it started.

Comment 2

[Rob Hudson [:robhudson]]

I'm planning on taking this along with bugs 769693 and 763053. However, comment #1 here conflicts with Andrew's comment (https://bugzilla.mozilla.org/show_bug.cgi?id=769693#c3) saying to push it to the queue and the reviewer can test it... odds being it shouldn't 404 for the reviewer if it was a hiccup. For simplicity I'll run with that unless otherwise directed. If there's too many false positives for reviewers we could tweak later.

Comment 3

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/d7c1b08