Closed
Bug 757860
Opened 12 years ago
Closed 12 years ago
Load JS HTTP server as a module
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: gps, Assigned: gps)
References
Details
(Whiteboard: [qa+])
Attachments
(1 file, 1 obsolete file)
|
14.89 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
Queued storage server and AITC server patches will require the JS HTTP server to be loaded as a module because those things are themselves being implemented as testing-only JS modules. This can't be checked in until bug 755196, bug 755339, and bug 757460 all land.
Attachment #626460 -
Flags: review?(rnewman)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 626460 [details] [diff] [review] Refactor test code to load JS HTTP server as a module Review of attachment 626460 [details] [diff] [review]: ----------------------------------------------------------------- Looks sane to me.
Attachment #626460 -
Flags: review?(rnewman) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
This is what the new patch looks like. The end state is the same as what was previously reviewed. The diff just looks nastier because of the order the patches needed to land in.
Assignee: nobody → gps
Attachment #626460 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #629166 -
Flags: review+
|
||
Updated•12 years ago
|
Whiteboard: [qa+]
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://hg.mozilla.org/services/services-central/rev/ea5eedb6ff46
Whiteboard: [qa+] → [qa+][fixed in services]
Target Milestone: --- → mozilla16
|
|
Assignee | |
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ea5eedb6ff46
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [qa+][fixed in services] → [qa+]
|
||
Updated•6 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•