Closed
Bug 757909
Opened 12 years ago
Closed 12 years ago
add in-tree mozconfigs for android/armv6 and android/x86
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla15
People
(Reporter: ted, Assigned: ted)
References
Details
Attachments
(1 file, 1 obsolete file)
11.48 KB,
patch
|
glandium
:
review+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
We should have mozconfigs in-tree for these to make things easy.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → ted.mielczarek
Assignee | ||
Comment 1•12 years ago
|
||
This patch just copies the existing android mozconfigs and tweaks them. I haven't tried the armv6 one, but it ought to work. (Should be able to push it to try and see.) I've built with the x86 one locally (with a few well-placed symlinks to get /tools in order), but it fails on try because of bug 756816. r?catlee on the directory layout, r?glandium on the mozconfig contents.
Attachment #626508 -
Flags: review?(mh+mozilla)
Attachment #626508 -
Flags: review?(catlee)
Comment 2•12 years ago
|
||
Comment on attachment 626508 [details] [diff] [review] mozconfigs for android-armv6 and android-x86 Review of attachment 626508 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/config/mozconfigs/android/debug @@ +5,5 @@ > # Build Fennec > ac_add_options --enable-application=mobile/android > > # Android > ac_add_options --target=arm-linux-androideabi Probably makes no difference, but I've always been using i686-linux-android. @@ +11,5 @@ > ac_add_options --with-endian=little > ac_add_options --with-android-ndk="/tools/android-ndk-r5c" > ac_add_options --with-android-sdk="/tools/android-sdk-r15/platforms/android-14" > ac_add_options --with-android-tools="/tools/android-sdk-r15/tools" > ac_add_options --with-android-toolchain=/tools/android-ndk-r5c/toolchains/arm-linux-androideabi-4.4.3/prebuilt/linux-x86 You should start from the new android mozconfigs (after bug 751265). Most of this is unneeded.
Attachment #626508 -
Flags: review?(mh+mozilla) → review-
Assignee | ||
Comment 3•12 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #2) > Comment on attachment 626508 [details] [diff] [review] > mozconfigs for android-armv6 and android-x86 > > Review of attachment 626508 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: mobile/android/config/mozconfigs/android/debug > @@ +5,5 @@ > > # Build Fennec > > ac_add_options --enable-application=mobile/android > > > > # Android > > ac_add_options --target=arm-linux-androideabi > > Probably makes no difference, but I've always been using i686-linux-android. Presumably you meant to make that comment on the x86 mozconfig, not the armv6 one? > You should start from the new android mozconfigs (after bug 751265). Most of > this is unneeded. Ok, thanks.
Comment 4•12 years ago
|
||
(In reply to Ted Mielczarek [:ted] from comment #3) > Presumably you meant to make that comment on the x86 mozconfig, not the > armv6 one? indeed, although i think i really did, and i wouldn't be surprised that splinter review was just confused by the file copies.
Comment 5•12 years ago
|
||
Comment on attachment 626508 [details] [diff] [review] mozconfigs for android-armv6 and android-x86 Review of attachment 626508 [details] [diff] [review]: ----------------------------------------------------------------- directory structure looks fine
Attachment #626508 -
Flags: review?(catlee) → review+
Assignee | ||
Comment 6•12 years ago
|
||
Rebased on top of bug 751265.
Attachment #626886 -
Flags: review?(mh+mozilla)
Assignee | ||
Updated•12 years ago
|
Attachment #626508 -
Attachment is obsolete: true
Comment 7•12 years ago
|
||
Comment on attachment 626886 [details] [diff] [review] mozconfigs for android-armv6 and android-x86 Review of attachment 626886 [details] [diff] [review]: ----------------------------------------------------------------- Please remove that extra line you add to mobile/android/config/mozconfigs/android-x86/nightly. (FWIW, Splinter review *is* confused by the copied files)
Attachment #626886 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 8•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad71b887061f
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla15
Comment 9•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ad71b887061f
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Comment 10•12 years ago
|
||
Comment on attachment 626886 [details] [diff] [review] mozconfigs for android-armv6 and android-x86 [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: can't build ARMv6 for Fx15 Testing completed (on m-c, etc.): landed on m-c when it was Fx16 Risk to taking this patch (and alternatives if risky): String or UUID changes made by this patch:
Attachment #626886 -
Flags: approval-mozilla-beta?
Assignee | ||
Comment 11•12 years ago
|
||
There's no risk to these patches, they're mozconfigs for alternate build configurations. They have no impact on the existing build configurations.
Comment 12•12 years ago
|
||
Comment on attachment 626886 [details] [diff] [review] mozconfigs for android-armv6 and android-x86 no risk, mozconfigs only - approving.
Attachment #626886 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•