758048 - Use accelerated layers for <panels>

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Justin Dolske [:Dolske]]

+++ This bug was initially created as a clone of Bug #751370 +++

Bug 751370 was filed to "not use accelerated layers for small popups windows on Linux". The patch disables layers for <panel> too, though, which can contain arbitrarily complex content. We don't do that in Firefox (yet?), but I suppose some addon might use a <panel> for something that would benefit from this.

We should probably just exempt <panel> from the bug 751370 fix. (Or possibly make it an optin/optout thing? Not sure that complexity is worth it.)

Comment 1

[Nicolas Silva [:nical]]

Attachment: Allows acceleration of xul panels

This small patch does two things: 
 - it moves the PopupType() getter (and the mPopupType member) from windows's nsWindow class to the cross platform base class (nsBaseWidget), which makes more sense to me since the attribute is as relevent on linux or mac as it is on windows.
 - it uses the popup type when choosing whether or not we disable acceleration (allowing xul panels to be accelerated).

Comment 2

[Nicolas Silva [:nical]]

I just pushed the patch to try servers (I'd be surprised that it breaks something though).

Comment 3

[Nicolas Silva [:nical]]

try results look good.

Comment 4

[Justin Dolske [:Dolske]]

Comment on attachment 626672 [details] [diff] [review]
Allows acceleration of xul panels

(I can't review this, bouncing over.)

Comment 5

[Benoit Girard (:BenWa)]

Comment on attachment 626672 [details] [diff] [review]
Allows acceleration of xul panels

This is touching widget code, none of which is cocoa. Joe suggested bbondy to review this.

Comment 6

[Brian R. Bondy [:bbondy]]

Comment on attachment 626672 [details] [diff] [review]
Allows acceleration of xul panels

Review of attachment 626672 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 7

[Brian R. Bondy [:bbondy]]

I had a nit in another open window:

> bool isSmallPopup = ((mWindowType == eWindowType_popup)
> 		&& (mPopupType != ePopupTypePanel));

nit: Please put the && on the previous line and left-align to the right hand side of the equal sign.

Comment 8

[Nicolas Silva [:nical]]

Attachment: Allows acceleration of xul panels.

> > bool isSmallPopup = ((mWindowType == eWindowType_popup)
> > 		&& (mPopupType != ePopupTypePanel));
>
> nit: Please put the && on the previous line and left-align to the right hand > side of the equal sign.

Fixed :)

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 628808 [details] [diff] [review]
Allows acceleration of xul panels.

Just use checkin-needed.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e5fb5ad11849

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e5fb5ad11849