758242 - Provide feedback to user that we can't sync passwords with MP enabled

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Android Sync, defect, P5)

Description

[Wesley Johnston (:wesj)]

Bug 757646 made me realize we don't really provide any feedback to the user about Sync failing to sync passwords when MP is enabled. We should do something... a one time toast or notification? Or a description line in the settings activity?

Comment 1

[Richard Newman [:rnewman]]

We're working on a settings dialog to control what to sync. I'd suggest two places to surface this: one being that Sync settings dialog, and the other being a description line underneath the Master Password checkbox -- "Enabling Master Password will prevent Firefox Sync from synchronizing your passwords.".

That way a user is bound to see something in their path, without the annoyance of a toast.

Thoughts?

Comment 2

[Robert Pollak]

https://support.mozilla.org/en-US/questions/974139 ("Does Firefox for Android sync passwords from Firefox desktop?") is related.
(Btw., count me as another one hit by this bug.)

Comment 3

[Deb Richardson [:dria] (plz NEEDINFO)]

We do have to let the user know what's going on, but I'm going to let ibarlow sort out the how/where part.  So yes, we need this, but NEEDINFOing ibarlow for design-related decisions.

Eventually this should be moot, but that day is not upon us :)

Comment 4

[Richard Newman [:rnewman]]

Some relevant future context: Bug 973759 Comment 6, and the rest of the thread.

Deb, do you have a target release for this? If it's later than 31, we should probably just consider doing what I propose in that comment.

Comment 5

[Edwin Wong [:edwong]]

triage: polish bug

Comment 6

[Ian Barlow (:ibarlow)]

(In reply to Deb Richardson [:dria] from comment #3)
> We do have to let the user know what's going on, but I'm going to let
> ibarlow sort out the how/where part.  So yes, we need this, but NEEDINFOing
> ibarlow for design-related decisions.
> 
> Eventually this should be moot, but that day is not upon us :)

I'd rather we try to fix master password or remove it altogether first, instead of putting this little bandaid on the problem. 

yes, a note about "enabling this will make it so your passwords don't sync" would explain that small slice of Master Password to users, but it doesn't solve the bigger problem of master password not actually functioning as a feature in the way anyone expects it to, or that we don't actually explain it to them anywhere.

Comment 7

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 9

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.