758589 - "ASSERTION: Must have view manager" with mozRequestFullScreen, contenteditable, selection.toString

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Jesse Ruderman]

Attachment: testcase (requires focus) (click the button)

###!!! ASSERTION: Must have view manager: '!isSafeToFlush || mViewManager', file layout/base/nsPresShell.cpp, line 3719

Might be a regression from bug 748961, which added a Flush_Style to nsTypedSelection::ToString.

These variations do *not* assert:
  Using a fresh selection object        "" + window.getSelection();
  Forcing a full layout flush           document.documentElement.offsetHeight

Comment 1

[Jesse Ruderman]

Attachment: stack trace

Comment 2

[Mats Palmgren (inactive)]

Attachment: fix

GetPresShell use nsTypedSelection::mPresShellWeak which isn't nulled
out by DisconnectFromPresShell.  Maybe we should, but let's take this
safe patch for now.

https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=25c7876a569a

Comment 3

[Mats Palmgren (inactive)]

BTW, is Destroy'ing the pres shell expected when entering full screen mode?

Comment 4

[Timothy Nikkel (:tnikkel)]

(In reply to Mats Palmgren [:mats] from comment #3)
> BTW, is Destroy'ing the pres shell expected when entering full screen mode?

I think so, we change the position or display of some ancestor of the content document in chrome when we go into fullscreen, so it gets reframed.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 627317 [details] [diff] [review]
fix

This is safe.

Comment 6

[Mats Palmgren (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d605438199c

Comment 7

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/cf9f2ec36992 despite probably being harmless and just keeping bad company in that push. Something in that push caused bug 759243, which horrifies me so much I wanted to kill it with as much fire as possible.

Comment 8

[Mats Palmgren (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a67959f7dce

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3a67959f7dce