758595 - don't include CodeResources file in builds that aren't getting signed

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[[e-mail] (:bhearsum)]

As of bug 732176 we're shipping a Contents/_CodeSignature/CodeResources in every mac build. 
It'd be good to stop doing this for builds that don't have a MOZ_SIGN_CMD, since we know we won't be signing them.

Comment 1

[[e-mail] (:bhearsum)]

Unfortunately, we don't have any existing variables (that I can find) that will let us accomplish this....maybe we can create a new one in configure.in based on the value of MOZ_SIGN_CMD.

Comment 2

[[e-mail] (:bhearsum)]

wip on https://github.com/bhearsum/mozilla-central/tree/no-coderesources-unsigned

Comment 3

[[e-mail] (:bhearsum)]

Attachment: don't include CodeResources when MOZ_SIGNING isn't set

I did my best to test this on try by adding a "export MOZ_SIGN_CMD=" at the top of the configure.in hunk. That ended up causing signing errors, because MOZ_SIGN_CMD was set during "make package" but CodeResources was missing. To me, that indicates success :).

Comment 4

[[e-mail] (:bhearsum)]

We need to port this to Thunderbird, too.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 627785 [details] [diff] [review]
don't include CodeResources when MOZ_SIGNING isn't set

http://hg.mozilla.org/mozilla-central/rev/0f2b57130b26

Comment 6

[[e-mail] (:bhearsum)]

Landed cleanly.