758670 - Use stdint types instead of stdin ones in dom

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[Mounir Lamouri (:mounir)]

Comment on attachment 627256 [details] [diff] [review]
Patch v1

Review of attachment 627256 [details] [diff] [review]:
-----------------------------------------------------------------

Do we have a policy regarding this? Shouldn't we use NSPR types instead when possible?
The patch seems ok assuming we want it.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

The JSAPI uses stdint types, and the PR* ones may or may not be typedef'd to something close enough not to break, say, BSD.

Comment 3

[Mounir Lamouri (:mounir)]

Comment on attachment 627256 [details] [diff] [review]
Patch v1

Review of attachment 627256 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the comments applied.

::: content/canvas/src/nsCanvasRenderingContext2D.cpp
@@ +4035,5 @@
>              if (!checkedDirtyX.isValid())
>                  return NS_ERROR_DOM_INDEX_SIZE_ERR;
>  
>              dirtyX = checkedDirtyX.value();
> +            dirtyWidth = -int32_t(dirtyWidth);

Why not simply |dirtyWidth = -dirtyWidth;|?

@@ +4047,5 @@
>              if (!checkedDirtyY.isValid())
>                  return NS_ERROR_DOM_INDEX_SIZE_ERR;
>  
>              dirtyY = checkedDirtyY.value();
> +            dirtyHeight = -int32_t(dirtyHeight);

ditto

::: content/canvas/src/nsCanvasRenderingContext2DAzure.cpp
@@ +4205,5 @@
>        if (!checkedDirtyX.isValid())
>            return NS_ERROR_DOM_INDEX_SIZE_ERR;
>  
>        dirtyX = checkedDirtyX.value();
> +      dirtyWidth = -int32_t(dirtyWidth);

ditto

@@ +4217,5 @@
>        if (!checkedDirtyY.isValid())
>            return NS_ERROR_DOM_INDEX_SIZE_ERR;
>  
>        dirtyY = checkedDirtyY.value();
> +      dirtyHeight = -int32_t(dirtyHeight);

ditto

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/f637cf042c82