Closed
Bug 758683
Opened 12 years ago
Closed 12 years ago
Change the pause icon to a play icon in the debugger toolbar
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 15
People
(Reporter: rcampbell, Assigned: rcampbell)
References
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(4 files, 2 obsolete files)
The Pause icon is usually not what you're interested in. The activity we perform most-frequently is "Resuming execution" which is more of a "Play" action than "Pause". We have options: 1. Always use a Play icon instead of Pause. 2. Switch between Play and Pause depending on state (checked would switch to Play, unchecked would be Pause). 3. Incorporate a single Play/Pause button that doesn't change. The |> button.
Assignee | ||
Comment 1•12 years ago
|
||
Paul suggests option 1. Always use the Play icon. I'm inclined to say yes, let's do this for this release. Later on when we have the Threads panel we'll need to be able to pause workers and the pause button may make sense for that.
Comment 2•12 years ago
|
||
Assignee | ||
Comment 3•12 years ago
|
||
yes!
Assignee | ||
Updated•12 years ago
|
Summary: Investigate adding a play icon to the debugger toolbar in place of pause → Change the pause icon to a play icon in the debugger toolbar
Comment 4•12 years ago
|
||
Currently there is no icon for the "play/pause" button when the script is not paused on Win7. I'm not sure if this bug is meant to add the icon there, or if this bug is supposed to change the icon that is supposed to be there. See this screenshot for an example of what I'm talking about: http://screencast.com/t/jbptmYe93X
Comment 5•12 years ago
|
||
Confirmed the missing pause icon. This patch should fix it, although my Win VM will take a while to verify this.
Attachment #628675 -
Flags: review?(rcampbell)
Comment 6•12 years ago
|
||
(In reply to Panos Astithas [:past] from comment #5) > Created attachment 628675 [details] [diff] [review] > Windows fix for the pause icon > > Confirmed the missing pause icon. This patch should fix it, although my Win > VM will take a while to verify this. Fix verified.
Assignee | ||
Comment 7•12 years ago
|
||
this isn't really the bug for that. This is about replacing the pause icons with play icons. I'll have a patch ready (that includes windows) today.
Assignee | ||
Comment 8•12 years ago
|
||
ok, here it is. I left the pause icon in place figuring well want it again.
Assignee: nobody → rcampbell
Attachment #628675 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #628675 -
Flags: review?(rcampbell)
Attachment #628907 -
Flags: review?(past)
Assignee | ||
Comment 9•12 years ago
|
||
Assignee | ||
Comment 10•12 years ago
|
||
Attachment #628907 -
Attachment is obsolete: true
Attachment #628907 -
Flags: review?(past)
Attachment #628929 -
Flags: review?(dcamp)
Assignee | ||
Comment 11•12 years ago
|
||
Updated•12 years ago
|
Attachment #628929 -
Flags: review?(dcamp) → review+
Assignee | ||
Updated•12 years ago
|
Whiteboard: [land-in-fx-team]
Assignee | ||
Comment 12•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/5d7b03e92502
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Assignee | ||
Comment 13•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5d7b03e92502
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•