Closed Bug 758683 Opened 12 years ago Closed 12 years ago

Change the pause icon to a play icon in the debugger toolbar

Categories

(DevTools :: Debugger, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 15

People

(Reporter: rcampbell, Assigned: rcampbell)

References

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(4 files, 2 obsolete files)

The Pause icon is usually not what you're interested in. The activity we perform most-frequently is "Resuming execution" which is more of a "Play" action than "Pause".

We have options:

1. Always use a Play icon instead of Pause.
2. Switch between Play and Pause depending on state (checked would switch to Play, unchecked would be Pause).
3. Incorporate a single Play/Pause button that doesn't change. The |> button.
Blocks: minotaur
Paul suggests option 1. Always use the Play icon. I'm inclined to say yes, let's do this for this release. Later on when we have the Threads panel we'll need to be able to pause workers and the pause button may make sense for that.
Attached image Play Icon
yes!
Summary: Investigate adding a play icon to the debugger toolbar in place of pause → Change the pause icon to a play icon in the debugger toolbar
Currently there is no icon for the "play/pause" button when the script is not paused on Win7. I'm not sure if this bug is meant to add the icon there, or if this bug is supposed to change the icon that is supposed to be there.

See this screenshot for an example of what I'm talking about: 
http://screencast.com/t/jbptmYe93X
Attached patch Windows fix for the pause icon (obsolete) — Splinter Review
Confirmed the missing pause icon. This patch should fix it, although my Win VM will take a while to verify this.
Attachment #628675 - Flags: review?(rcampbell)
(In reply to Panos Astithas [:past] from comment #5)
> Created attachment 628675 [details] [diff] [review]
> Windows fix for the pause icon
> 
> Confirmed the missing pause icon. This patch should fix it, although my Win
> VM will take a while to verify this.

Fix verified.
this isn't really the bug for that. This is about replacing the pause icons with play icons.

I'll have a patch ready (that includes windows) today.
Attached patch play icons (obsolete) — Splinter Review
ok, here it is.

I left the pause icon in place figuring well want it again.
Assignee: nobody → rcampbell
Attachment #628675 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #628675 - Flags: review?(rcampbell)
Attachment #628907 - Flags: review?(past)
Attached image mac screenshot
Attached patch play icons v1Splinter Review
Attachment #628907 - Attachment is obsolete: true
Attachment #628907 - Flags: review?(past)
Attachment #628929 - Flags: review?(dcamp)
Attached image windows screenshot
Attachment #628929 - Flags: review?(dcamp) → review+
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/5d7b03e92502
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/5d7b03e92502
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: